[Zeppelin 329] Notebook copied in file system level should be reflected in notebook list#331
[Zeppelin 329] Notebook copied in file system level should be reflected in notebook list#331minahlee wants to merge 3 commits intoapache:masterfrom
Conversation
|
Nice improvement. Could you choose little more intuitive name than |
|
@Leemoonsoo @khalidhuseynov ready for review |
|
why do you need to activate this functionality? shouldnt be a expected behavior? |
|
Beacause this PR will load notebooks from storage everytime client requests notebook list, which can be burden to Zeppelin with a bunch of notebooks. So I wanted to make as less effect as possible on current behavior. Would it be better to activate it by default? |
|
so why not using a watcher? like if someone drop a notebook in the notebook dir, you update the list of notebook. |
|
I think activating this function by default will brings some IO overhead in some cases. (large number of big notebooks). As @minahlee mentioned, it's better to keep it de-activated by default. When the implementation becomes more efficient it can be activated by default. That could be future work. |
|
Merging if there're no more discussions |
This PR resolves https://issues.apache.org/jira/browse/ZEPPELIN-367 by synchronizing with secondary storage when reloading all notebooks into memory. Currently, existing `ZEPPELIN_NOTEBOOK_RELOAD_FROM_STORAGE` from #331 is used as a flag since these functionalities are correlated, however it can be separated into distinct flag as well. Author: Khalid Huseynov <khalidhnv@nflabs.com> Closes #375 from khalidhuseynov/sync-on-list and squashes the following commits: e2cf5d9 [Khalid Huseynov] minor fix 878a23e [Khalid Huseynov] initial working commit
4 participants
This PR enables Zeppelin to reflect addition/changes/removal of
{ZEPPELIN_NOTEBOOK_DIR}/{notebookId}/note.jsonon the file system without restarting ZeppelinServer.To activate this functionality, user needs to set
ZEPPELIN_NOTEBOOK_GET_FROM_REPOto be true in conf/zeppelin-env.sh.